chore(cleanup): Remove the AppConfig and KeyManager singletons #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
========================================
+ Coverage 8.99% 9.04% +0.04%
========================================
Files 99 99
Lines 7761 7809 +48
========================================
+ Hits 698 706 +8
- Misses 6989 7030 +41
+ Partials 74 73 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
1 task
mcamou
changed the title
mcamou
changed the title
mcamou
changed the title
mcamou
changed the title
mudler
reviewed
Nov 12, 2024
mudler
previously approved these changes
Nov 12, 2024
Co-authored-by: Ettore Di Giacinto <[email protected]> Signed-off-by: Mario Camou <[email protected]>
mudler
approved these changes
Nov 12, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Singletons are a bad practice which makes it difficult to write proper tests for the code. This PR (almost) removes the two singletons we have:
AppConfigsingleton, used throughout the codebase to get access to the node configurationKeyManagersingleton, used to get access to private and public keysWe remove both singletons in one go since it is very complicated to remove just
AppConfigwithout removingKeyManager. They are replaced either with functional options, by adding some fields to other objects (i.e.OracleNode) or, in cases where there are just one or config parameter needed in one place in the code, passing them directly as parameters.This PR removes
config.GetInstance()from everywhere except the Sentiment-related files, since those will be removed as part of a separate PR (see #626).Notes to reviewers
If the full PR is a bit much, the commit history should be more manageable. If preferred, I could split this into multiple PRs.
Signed commits